Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 )
Change subject: IMPALA-8041, Part 2: Refactor SELECT list ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java File fe/src/main/java/org/apache/impala/analysis/SelectListItem.java: http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java@108 PS1, Line 108: * Hive's auto-generated column labels have a "_c" prefix and a select-list pos suffix, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/SelectListItem.java@219 PS1, Line 219: public static SelectWildcard asWildcard(SelectListItem item) { return (SelectWildcard) item; } line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@290 PS1, Line 290: if (existingAliasExpr != null && !existingAliasExpr.equals(selectExpr.getExpr())) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/12144/1/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@261 PS1, Line 261: new SelectList(Lists.newArrayList(SelectListItem.createColumn(wrapperResult, null))), line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e173dad717e739c097f1f0cd86a0352648ff886 Gerrit-Change-Number: 12144 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Jan 2019 06:56:47 +0000 Gerrit-HasComments: Yes
