Janaki Lahorani has posted comments on this change. ( http://gerrit.cloudera.org:8080/12113 )
Change subject: IMPALA-6533: Add min-max filter for decimal types on kudu tables. ...................................................................... Patch Set 17: (4 comments) Thanks Thomas and Tim. Patchset 17 addresses all comments from Thomas and Tim. http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/runtime/decimal-value.h File be/src/runtime/decimal-value.h: http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/runtime/decimal-value.h@199 PS14, Line 199: Store > nit: /// Done http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/util/min-max-filter-ir.cc File be/src/util/min-max-filter-ir.cc: http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/util/min-max-filter-ir.cc@95 PS14, Line 95: INSERT_DECIMAL_MINMAX(4); > So this is pretty perf-sensitive code (executed once per row on the build s Thanks Thomas. As discussed with you, I changed the code to use 3 different functions for 3 different sizes. http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/util/min-max-filter.h File be/src/util/min-max-filter.h: http://gerrit.cloudera.org:8080/#/c/12113/14/be/src/util/min-max-filter.h@298 PS14, Line 298: > I think that you can just use ColumnType::GetDecimalByteSize() instead of d Done http://gerrit.cloudera.org:8080/#/c/12113/13/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/12113/13/tests/query_test/test_runtime_filters.py@116 PS13, Line 116: if self.exploration_strategy() != 'exhaustive': > Hmm, alright. It doesn't make much sense to me to split the decimal-related Done -- To view, visit http://gerrit.cloudera.org:8080/12113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e7278e902160d7060f8097290bc172d9031f94 Gerrit-Change-Number: 12113 Gerrit-PatchSet: 17 Gerrit-Owner: Janaki Lahorani <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Janaki Lahorani <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 08 Jan 2019 23:44:32 +0000 Gerrit-HasComments: Yes
