Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 )
Change subject: WIP IMPALA-7550 Add documentation to profile counters ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12116/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/12116/2/be/src/runtime/coordinator.cc@68 PS2, Line 68: PROFILE_DEFINE_COUNTER(NumBackends, stable, TUnit::UNIT, "Number of backends running this query"); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/12116/2/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/12116/2/be/src/util/runtime-profile-counters.h@94 PS2, Line 94: ::impala::CounterPrototype PROFILE_##name(#name, ProfileEntryPrototype::Stability::stability, desc, unit) line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/12116/2/be/src/util/runtime-profile-counters.h@96 PS2, Line 96: ::impala::RateCounterPrototype PROFILE_##name(#name, ProfileEntryPrototype::Stability::stability, desc, unit) line too long (111 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa0a44f0a996f3487566b545d984d562e6e1588 Gerrit-Change-Number: 12116 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 22:02:11 +0000 Gerrit-HasComments: Yes
