Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12116 )
Change subject: WIP IMPALA-7550 Add documentation to profile counters ...................................................................... Patch Set 1: > (1 comment) Thanks for the feedback. I added a stability field, let me know what you think. We have ~200 counters it seems: git grep -E "ADD_TIMER|ADD_COUNTER|ADD_TIME_SERIES_COUNTER|ADD_SUMMARY_STATS_COUNTER|ADD_CHILD_TIMER" | wc -l I can't think of a good way to make this change mechanically, so I'm leaning towards doing this in several stages to prevent a large change from rotting away in review. With the main plumbing in we can also start to work on the documentation side of things, e.g. generate useful docs. Would you prefer a large, atomic change instead? -- To view, visit http://gerrit.cloudera.org:8080/12116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa0a44f0a996f3487566b545d984d562e6e1588 Gerrit-Change-Number: 12116 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 22:06:43 +0000 Gerrit-HasComments: No
