Lars Volker has posted comments on this change. (
http://gerrit.cloudera.org:8080/12116 )
Change subject: WIP IMPALA-7550 Add documentation to profile counters
......................................................................
Patch Set 1:
> It's hard to argue with documenting these.
>
> The other extreme position is just to do it in the Thrift, e.g. the
> following diff. In practice we might end up generating the thrift
> (and the docs).
>
> --- common/thrift/RuntimeProfile.thrift
> +++ common/thrift/RuntimeProfile.thrift
> @@ -92,6 +92,9 @@ struct TRuntimeProfileNode {
> 2: required i32 num_children
> 3: required list<TCounter> counters
>
> + // documentation...
> + 1000: TCounter bytes_read
> +
>
>
> If I were starting from scratch, I would definitely do this from
> Thrift. (This is how we do query options, btw, and I think it's
> largely fine, though we could do more code generation to avoid the
> annoyance.) Given where we are, I think your approach is probably
> more incremental, which is good.
Thanks for the feedback. Having profile counter prototypes properly registered
would also allow us to generate thrift fields, so in an incremental way we can
get there without having to throw away work.
--
To view, visit http://gerrit.cloudera.org:8080/12116
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa0a44f0a996f3487566b545d984d562e6e1588
Gerrit-Change-Number: 12116
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 09 Jan 2019 22:07:48 +0000
Gerrit-HasComments: No
