Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 )
Change subject: [PREVIEW] Unified backend test executable ...................................................................... Patch Set 1: (3 comments) Rebased this, associated it with a JIRA, and fixed a few minor things. http://gerrit.cloudera.org:8080/#/c/12124/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12124/1//COMMIT_MSG@29 PS1, Line 29: > Does ctest -R still work? Double-checked this. Yes, it still works. Updated comment to add that. http://gerrit.cloudera.org:8080/#/c/12124/1/bin/gen-backend-test-script.sh File bin/gen-backend-test-script.sh: http://gerrit.cloudera.org:8080/#/c/12124/1/bin/gen-backend-test-script.sh@30 PS1, Line 30: ${IMPALA_HOME}/bin/junit_prune.py -f "${IMPALA_BE_TEST_LOGS_DIR}/${TEST_EXEC_NAME}.xml" > This pruning might need a bit more explanation Renamed that script and added a comment. http://gerrit.cloudera.org:8080/#/c/12124/1/bin/junit_prune.py File bin/junit_prune.py: http://gerrit.cloudera.org:8080/#/c/12124/1/bin/junit_prune.py@52 PS1, Line 52: if __name__ == "__main__": main() > flake8: E305 expected 2 blank lines after class or function definition, fou I don't get this error when running locally, and if I add a line, it complains about an extra line at the end of the file. Going to ignore this for now. -- To view, visit http://gerrit.cloudera.org:8080/12124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842 Gerrit-Change-Number: 12124 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 Jan 2019 21:05:35 +0000 Gerrit-HasComments: Yes
