Hello Michael Brown, David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12220
to look at the new patch set (#2).
Change subject: IMPALA-5847: Fix incorrect use of SET in .test files
......................................................................
IMPALA-5847: Fix incorrect use of SET in .test files
The '.test' files are used to run queries for tests. These files are
run with a vector of default query options. They also sometimes
include SET queries that modify query options. If SET is used on a
query option that is included in the vector, the default value from
the vector will override the value from the SET, leading to tests that
don't actually run with the query options they appear to.
This patch asserts that '.test' files don't use SET for values present
in the default vector. It also fixes various tests that already had
this incorrect behavior.
Testing:
- Passed a full exhaustive run.
Change-Id: I4e4c0f31bf4850642b624acdb1f6cb8837957990
---
M testdata/workloads/functional-query/queries/QueryTest/codegen-mem-limit.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test
A
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan-single-node.test
M
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
A
testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit-single-node.test
M
testdata/workloads/functional-query/queries/QueryTest/nested-types-tpch-mem-limit.test
A
testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive-no-default-buffer-size.test
M
testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test
A
testdata/workloads/functional-query/queries/QueryTest/subquery-single-node.test
M testdata/workloads/functional-query/queries/QueryTest/subquery.test
M testdata/workloads/tpch/queries/sort-reservation-usage.test
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_mt_dop.py
M tests/query_test/test_nested_types.py
M tests/query_test/test_queries.py
M tests/query_test/test_scanners.py
M tests/query_test/test_spilling.py
19 files changed, 163 insertions(+), 118 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/12220/2
--
To view, visit http://gerrit.cloudera.org:8080/12220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e4c0f31bf4850642b624acdb1f6cb8837957990
Gerrit-Change-Number: 12220
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
