Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12199 )
Change subject: IMPALA-8043: Fix BE test failures related to SystemV timezones. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12199/1//COMMIT_MSG@28 PS1, Line 28: It also adds 'SystemV' directory to the test timezone db to avoid : similar issues in the future. > I would generally prefer to set local tz explicitly in every test to avoid I think it is best to add SystemV to the tz db. http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/12199/1/be/src/exprs/expr-test.cc@6585 PS1, Line 6585: EXPECT_BETWEEN(unix_start_time, unix_timestamp_result, : static_cast<int64_t>(mktime(&after))); > I think that this test can fail during Autumn DST change. This failure is e Done. Changed the tz (here and elsewhere in the test) to "America/Anguilla" which doesn't observe DST. -- To view, visit http://gerrit.cloudera.org:8080/12199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9288cd24c8af0c059e55d47c86bd92eaf0075681 Gerrit-Change-Number: 12199 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Jan 2019 11:46:48 +0000 Gerrit-HasComments: Yes
