Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 )
Change subject: Support centos:7 for test-with-docker. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12139/1/bin/bootstrap_system.sh@253 PS1, Line 253: redhat6 sudo service ntpd start || grep docker /proc/1/cgroup > Do we need "redhat7 notindocker sudo service ntpd start"? In a "privileged" container this can actually run, so I didn't take this suggestion. http://gerrit.cloudera.org:8080/#/c/12139/1/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/12139/1/docker/entrypoint.sh@151 PS1, Line 151: sudo /usr/sbin/sshd > Curious: The bootstrap has this: We don't. The ssh-keygen generates /etc/ssh/hostkey (or something like it), and at this point, that key exists. -- To view, visit http://gerrit.cloudera.org:8080/12139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7577949b6eaaa2239bcf0fadf64e1490c2106b08 Gerrit-Change-Number: 12139 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 20:06:09 +0000 Gerrit-HasComments: Yes
