Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12189 )
Change subject: IMPALA-7988: support loading data with dockerized Impalas ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12189/5/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/12189/5/tests/common/impala_cluster.py@223 PS5, Line 223: _find_docker_containers > Nit: I believe you can make this fully private (__find_docker_containers) i Done -- To view, visit http://gerrit.cloudera.org:8080/12189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fb9c4f5a3a3bb15c7809eab28ec8e5f63ff517 Gerrit-Change-Number: 12189 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Jan 2019 17:28:22 +0000 Gerrit-HasComments: Yes
