Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 )
Change subject: IMPALA-7694: Add host resource usage metrics to profile ...................................................................... Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py File bin/plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@27 PS10, Line 27: d flake8: E501 line too long (162 > 90 characters) http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@31 PS10, Line 31: from impala_py_lib import profiles flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@32 PS10, Line 32: import argparse flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@33 PS10, Line 33: import sys flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@34 PS10, Line 34: import matplotlib flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/10/bin/plot_profile_resource_usage.py@36 PS10, Line 36: import matplotlib.pyplot as plt flake8: E402 module level import not at top of file http://gerrit.cloudera.org:8080/#/c/12069/10/lib/python/impala_py_lib/profiles.py File lib/python/impala_py_lib/profiles.py: http://gerrit.cloudera.org:8080/#/c/12069/10/lib/python/impala_py_lib/profiles.py@28 PS10, Line 28: def decode_profile_line(line): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/10/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/12069/10/tests/common/impala_service.py@91 PS10, Line 91: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/12069/10/tests/observability/test_plot_profile_resource_usage.py File tests/observability/test_plot_profile_resource_usage.py: http://gerrit.cloudera.org:8080/#/c/12069/10/tests/observability/test_plot_profile_resource_usage.py@25 PS10, Line 25: class TestPlotProfileResourceUsage(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12069/10/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12069/10/tests/query_test/test_observability.py@369 PS10, Line 369: e flake8: F841 local variable 'expected_strs' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/12069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aedc20c553ab8d7ed50f72a1a936eba151487d9 Gerrit-Change-Number: 12069 Gerrit-PatchSet: 10 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 18 Jan 2019 20:10:41 +0000 Gerrit-HasComments: Yes
