Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 )
Change subject: IMPALA-7979: Enhance decoders to support value-skipping ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12172/4/be/src/util/rle-test.cc File be/src/util/rle-test.cc: http://gerrit.cloudera.org:8080/#/c/12172/4/be/src/util/rle-test.cc@191 PS4, Line 191: esult > Is it really useful to print the values? At this point the same length + bi Yeah, you are right, now it prints values.size() and seed as well. http://gerrit.cloudera.org:8080/#/c/12172/4/be/src/util/rle-test.cc@275 PS4, Line 275: > It would make sense to do this randomly too, but I am leaning towards creat I like this idea, and it is very important that the decoders work correctly, so I implemented this approach. Benchmarking would be interesting, and we also talked about it offline, the conclusion was that it would be a good warm-up task for a newcomer. -- To view, visit http://gerrit.cloudera.org:8080/12172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib848f1bd71735fe84e8064daf700417b32589f57 Gerrit-Change-Number: 12172 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 21 Jan 2019 16:59:05 +0000 Gerrit-HasComments: Yes
