Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12129 )
Change subject: IMPALA-6664: Tag log statements with fragment or query ids. ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/common/thread-debug-info.h File be/src/common/thread-debug-info.h: http://gerrit.cloudera.org:8080/#/c/12129/2/be/src/common/thread-debug-info.h@a116 PS2, Line 116: > Thanks! Do you plan to fix it in this change, or in a follow-up commit? Thanks for catching that I didn't do this. I fixed it. Turned out to be nice and easy. http://gerrit.cloudera.org:8080/#/c/12129/5/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/12129/5/be/src/service/impala-hs2-server.cc@126 PS5, Line 126: ScopedThreadContext(GetThreadDebugInfo(), query_ctx.query_id); > Currently it creates a temporary object that is deleted promptly. Whoops. Thanks for catching this. Done. http://gerrit.cloudera.org:8080/#/c/12129/5/be/src/service/impala-internal-service.cc File be/src/service/impala-internal-service.cc: http://gerrit.cloudera.org:8080/#/c/12129/5/be/src/service/impala-internal-service.cc@49 PS5, Line 49: ScopedThreadContext(GetThreadDebugInfo(), params.query_ctx.query_id); > It creates a temporary that is deleted promptly. Done -- To view, visit http://gerrit.cloudera.org:8080/12129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6634ef9d1a7346339f24f2d40a7a3aa36a535da8 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 22 Jan 2019 20:46:54 +0000 Gerrit-HasComments: Yes
