Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 )
Change subject: IMPALA-7934: Switch to java.util.Base64 implementation ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12250/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12250/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-7934: Switch to java.util.Base64 implementation I'm pretty sure it is compatible with commons' base64 but could you please double check manually (if you haven't already done so)? Basically by creating a table with incremental stats (or persistent functions) without the patch, then trying to read them after applying this patch. http://gerrit.cloudera.org:8080/#/c/12250/2//COMMIT_MSG@14 PS2, Line 14: Did you see any perf improvements in the loading time of large tables with incremental stats? -- To view, visit http://gerrit.cloudera.org:8080/12250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d43d4a4f073a800d963ce4c77f21c9efa8471ac Gerrit-Change-Number: 12250 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Jan 2019 21:21:54 +0000 Gerrit-HasComments: Yes
