Zoltan Ivanfi has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12247 )

Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet
......................................................................


Patch Set 5:

> About 'parquet-tools dump': it would be great to use it during
 > Impala EE tests, but adding it as a dependency would also mean +1
 > way Impala builds can break, so I am not sure at the moment.

I am very confident that we should have this extra check.

Adding parquet-tools to the build toolchain is not that difficult as it does 
not have to be installed. I created a small Maven project that runs it without 
installing it (in the conventional sense at least). The whole project consists 
of a single POM file and nothing else. Feel free to add it to Implala and 
modify it to fit your needs: https://github.com/zivanfi/parquet-tools-executor


--
To view, visit http://gerrit.cloudera.org:8080/12247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41ad532ec902ed5a9a1528513726eac1c11441f
Gerrit-Change-Number: 12247
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Zoltan Ivanfi <[email protected]>
Gerrit-Comment-Date: Thu, 24 Jan 2019 14:04:32 +0000
Gerrit-HasComments: No

Reply via email to