Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12238 )
Change subject: IMPALA-8090: race when reusing ScanRange in test ...................................................................... IMPALA-8090: race when reusing ScanRange in test The issue occurs in test code where two reads are issued with the same ScanRange object back-to-back, e.g. in SyncReadTest. The DiskIoMgr enqueues the last buffer or cancels the scan range *before* closing the 'file_reader_', which means that the client thread thinks the ScanRange is done and can re-enqueue it into the DiskIoMgr. This is not an issue in Impala itself because scan ranges are not reused in this fashion. I evaluated adding a DCHECK but the lifecycle of the ScanRange objects is complicated enough that there wasn't a straightforward invariant to enforce. Testing: Looped the previously-failing test overnight. Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b Reviewed-on: http://gerrit.cloudera.org:8080/12238 Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc 2 files changed, 14 insertions(+), 8 deletions(-) Approvals: Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b Gerrit-Change-Number: 12238 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
