Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12277 )
Change subject: IMPALA-8062: Call impala-config in single_node_perf_run ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12277/1//COMMIT_MSG@11 PS1, Line 11: variables are set properly. How did you test? http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/12277/1/bin/single_node_perf_run.py@84 PS1, Line 84: cmd = " ".join(cmd) Might not be a major issue in practice, but it would be better run to run the tokens through pipes.quote() to make sure that it doesn't get re-tokenized by the shell in the wrong way. -- To view, visit http://gerrit.cloudera.org:8080/12277 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c1b77906a975c37f3b51a0f900ed3536b398ba Gerrit-Change-Number: 12277 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 26 Jan 2019 01:48:02 +0000 Gerrit-HasComments: Yes
