Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 )
Change subject: IMPALA-7450. Set thread name during refresh/load operations ...................................................................... Patch Set 2: (6 comments) Lgtm. There are quite a few places where we could use this annotator but that is definitely out of scope for this patch. There are a couple of interesting ones I pointed to in the comments that we could start with. Really liked the test, thanks for adding it :-) http://gerrit.cloudera.org:8080/#/c/11228/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11228/2//COMMIT_MSG@24 PS2, Line 24: This patch is tricky to automate tests for, but I verified it manually : by jstacking a catalogd while performing some workload. Also added a : simple unit test to verify the thread renaming behavior Can be removed I guess. http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@301 PS2, Line 301: long end; Annotate here? This is one of those common interesting entry points for table locks where the threads are usually hung. Waiting to lock <tblname>. http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2185 PS2, Line 2185: private TGetPartialCatalogObjectResponse doGetPartialCatalogObject( This is another interesting entry point RPC for catalog v2 stuff. Add some annotations here? http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java File fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java: http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@24 PS2, Line 24: public class ThreadNameAnnotatorTest { great test :-) http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@44 PS2, Line 44: wait(); nit: I hope nothing hangs here forever due to a faulty test? Add a largish timeout? http://gerrit.cloudera.org:8080/#/c/11228/2/fe/src/test/java/org/apache/impala/util/ThreadNameAnnotatorTest.java@107 PS2, Line 107: public void testExternalRename() throws InterruptedException { nit: Add a doc of what it does? Probably difficult to understand without any context. -- To view, visit http://gerrit.cloudera.org:8080/11228 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c850d6bb2eedc375ee567c19eb17add335f60c Gerrit-Change-Number: 11228 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sun, 27 Jan 2019 06:52:06 +0000 Gerrit-HasComments: Yes
