Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 )
Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog ...................................................................... Patch Set 3: Code-Review+1 (4 comments) lgtm (pending nits). I'll let Todd take a pass in case he has some comments. http://gerrit.cloudera.org:8080/#/c/11158/2/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java File fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java: http://gerrit.cloudera.org:8080/#/c/11158/2/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java@62 PS2, Line 62: */ > Documentation of this kind tends to get out of date quickly. Looking at the Fair point. http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java File fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java: http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java@22 PS3, Line 22: import org.apache.curator.shaded.com.google.common.base.Preconditions; Switch to guava jar. http://gerrit.cloudera.org:8080/#/c/11158/3/fe/src/main/java/org/apache/impala/catalog/CatalogInterners.java@115 PS3, Line 115: Preconditions.checkNotNull(sd); I think we should be conservative here (and other places) and do something like "if (sd == null) return;". Otherwise this unchecked exception can cause table loading failures and it not recoverable unless we patch it again. http://gerrit.cloudera.org:8080/#/c/11158/2/fe/src/main/java/org/apache/impala/catalog/HBaseColumn.java File fe/src/main/java/org/apache/impala/catalog/HBaseColumn.java: http://gerrit.cloudera.org:8080/#/c/11158/2/fe/src/main/java/org/apache/impala/catalog/HBaseColumn.java@35 PS2, Line 35: columnQualifier > According to this link: https://www.dummies.com/programming/big-data/hadoop Thanks for the info. -- To view, visit http://gerrit.cloudera.org:8080/11158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3121aefa4391bcb1477d9dba0a49440d7000d26 Gerrit-Change-Number: 11158 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 06:37:22 +0000 Gerrit-HasComments: Yes
