Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12287 )
Change subject: IMPALA-8093: Profiles prefix counters inconsistently ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12287/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12287/1//COMMIT_MSG@7 PS1, Line 7: Profiles prefix counters inconsistently We usually include what the patch does rather than the description of the bug itself. Something like, "Prefix time series counters with a hyphen" http://gerrit.cloudera.org:8080/#/c/12287/1/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/12287/1/tests/query_test/test_runtime_filters.py@72 PS1, Line 72: if re.search(" MemoryUsage", result.runtime_profile) is not None: : # MemoryUsage is a Time series counter, it should start with " - ", not " " : assert re.search(" MemoryUsage", result.runtime_profile) is None : assert re.search("- MemoryUsage", result.runtime_profile) is not None Seems out of place here. I'd guess this is a good candidate for test_observability.py. Lars, what do you think? -- To view, visit http://gerrit.cloudera.org:8080/12287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7184bc69c2816a9721390bcf424a549321a88b2f Gerrit-Change-Number: 12287 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Tue, 29 Jan 2019 00:47:57 +0000 Gerrit-HasComments: Yes
