Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12297 )
Change subject: IMPALA-8138: Reintroduce rpc debugging options ...................................................................... Patch Set 1: (1 comment) This all looks good but I have questions... http://gerrit.cloudera.org:8080/#/c/12297/1/be/src/runtime/krpc-backend-client.h File be/src/runtime/krpc-backend-client.h: http://gerrit.cloudera.org:8080/#/c/12297/1/be/src/runtime/krpc-backend-client.h@28 PS1, Line 28: class KrpcBackendClient : public ControlServiceProxy > Hmm...what about DataStreamService ? This seems to be a client for ControlS Should this class show that it is a decorated form of ControlServiceProxy, perhaps by having ControlServiceProxy as part of it's name? ControlServiceProxyInjected? ControlServiceProxyDecorated? I think this change introduces a convention, that we expect ControlServiceProxy methods to be overridden in KrpcBackendClient? If that's so then a comment somewhere should say that. Is it in fact now a mistake to use ControlServiceProxy? It seems like KrpcBackendClient is mostly boilerplate. Did you consider extending protoc-gen-krpc.cc to either generate the decorated methods in ControlServiceProxy, or to generate KrpcBackendClient? -- To view, visit http://gerrit.cloudera.org:8080/12297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2046cb9dadf846ea90c04e95781b2bbde3325941 Gerrit-Change-Number: 12297 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Wed, 30 Jan 2019 20:24:49 +0000 Gerrit-HasComments: Yes
