Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11782 )
Change subject: test-with-docker: decrease image size by "de-duping" HDFS. ...................................................................... Patch Set 1: (1 comment) > (1 comment) > > You know what somebody once said about shell scripts getting too > big? Yes, I definitely think this is crossing that threshold, but don't want to re-write it quite yet. http://gerrit.cloudera.org:8080/#/c/11782/1/docker/entrypoint.sh File docker/entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/11782/1/docker/entrypoint.sh@228 PS1, Line 228: set +x > Do you need to keep this? Yes, this avoids a lot of verbosity for every copy. It's undone in line 238. -- To view, visit http://gerrit.cloudera.org:8080/11782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a13910ba5e873c31893dbb810a8410547adb2f1 Gerrit-Change-Number: 11782 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Jan 2019 22:47:12 +0000 Gerrit-HasComments: Yes
