Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 )
Change subject: IMPALA-4555: Make QueryState's status reporting more robust ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12049/5/tests/custom_cluster/test_rpc_timeout.py File tests/custom_cluster/test_rpc_timeout.py: http://gerrit.cloudera.org:8080/#/c/12049/5/tests/custom_cluster/test_rpc_timeout.py@158 PS5, Line 158: # Since the sleep time (1000ms) is much longer than the rpc timeout (100ms), all : # reports will appear to fail. The query is designed to result in many intermediate : # status reports but fewer than the max allowed failures, so the query should succeed. : query_options = {'debug_action': 'REPORT_EXEC_STATUS_DELAY:SLEEP@1000'} > Sure, happy to write such a test if you think there's additional value in i Thanks for pointing out the insert errors below. LGTM. -- To view, visit http://gerrit.cloudera.org:8080/12049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6007013fc2c9e8eeba11b752ee58fb3038da971 Gerrit-Change-Number: 12049 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 07 Feb 2019 02:46:45 +0000 Gerrit-HasComments: Yes
