Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 )
Change subject: IMPALA-8071: Initial unified backend test framework ...................................................................... Patch Set 3: (1 comment) I'll wait for the ok to review. http://gerrit.cloudera.org:8080/#/c/12124/3/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12124/3/be/src/util/CMakeLists.txt@149 PS3, Line 149: ADD_UNIFIED_BE_LSAN_TEST(benchmark-test "BenchmarkTest.*") > Yes, I am worried that the patterns might get stale or people might forget I think we can live with those limitations - at least they don't mean losing coverage. -- To view, visit http://gerrit.cloudera.org:8080/12124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia03ef38719b1fbc0fe2025e16b7b3d3dd4488842 Gerrit-Change-Number: 12124 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Feb 2019 22:46:33 +0000 Gerrit-HasComments: Yes
