Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12403 )

Change subject: Add raw values to pretty-printed time profiles.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12403/1/be/src/util/pretty-printer.h
File be/src/util/pretty-printer.h:

http://gerrit.cloudera.org:8080/#/c/12403/1/be/src/util/pretty-printer.h@96
PS1, Line 96:         if (verbose) ss << " (" << value << "ns)";
Should we convert them all to a common unit to make parsing even easier?



--
To view, visit http://gerrit.cloudera.org:8080/12403
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3034482b3643968ac9e931bb28692e68b5a709c2
Gerrit-Change-Number: 12403
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Comment-Date: Fri, 08 Feb 2019 09:47:27 +0000
Gerrit-HasComments: Yes

Reply via email to