Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12412/2/tests/comparison/cluster.py File tests/comparison/cluster.py: http://gerrit.cloudera.org:8080/#/c/12412/2/tests/comparison/cluster.py@846 PS2, Line 846: def find_pid(self): : # Need to filter results to avoid pgrep picking up its parent bash script. : # Test with: : # sh -c "pgrep -l -f 'impala.*21050' | grep [i]mpalad | grep -o '^[0-9]*' || true" : pid = self.shell("pgrep -l -f 'impalad.*%s' | grep [i]mpalad | " : "grep -o '^[0-9]*' || true" % self.hs2_port) : if pid: : return int(pid) I'm fine with this, but this is $fuser 21050/tcp 21050/tcp: 2820 or possibly $pgrep impalad | head -n 1 2820 -- To view, visit http://gerrit.cloudera.org:8080/12412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4 Gerrit-Change-Number: 12412 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Brown <mi...@apache.org> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Feb 2019 17:47:54 +0000 Gerrit-HasComments: Yes
