Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12401 )
Change subject: IMPALA-8064: Improve observability of wait times for runtime filters ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12401/1/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/12401/1/be/src/exec/scan-node.cc@179 PS1, Line 179: max_wait_time = max(max_wait_time, ctx.filter->time_elapsed()); > If I understand it correctly, the point of these changes is to reflect the Thanks for the context Michael. Based on this it definitely seems like a good idea to add another time metric to the profile, and perhaps re-word the infoString to make it explicitly clear what each means. Naming it to something like "Max runtime filter wait time:" so that it directly relates to the query options as well, making it abundantly clear. http://gerrit.cloudera.org:8080/#/c/12401/1/be/src/runtime/runtime-filter.h File be/src/runtime/runtime-filter.h: http://gerrit.cloudera.org:8080/#/c/12401/1/be/src/runtime/runtime-filter.h@89 PS1, Line 89: time_elapsed you can probably replace arrival_delay() with this method and rename it to something like wait_time_ms(). The "Returns 0 if filter has not yet arrived" part in arrival_delay() is not used anywhere anyways. -- To view, visit http://gerrit.cloudera.org:8080/12401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28fd45e75c773bc01d424f5a179ae186ee9b7469 Gerrit-Change-Number: 12401 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Comment-Date: Fri, 08 Feb 2019 18:13:31 +0000 Gerrit-HasComments: Yes
