Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12429 )
Change subject: IMPALA-6035: Add query options to limit thread reservation ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12429/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/12429/1/be/src/scheduling/admission-controller.cc@468 PS1, Line 468: TNetworkAddressToString(*max_thread_reservation.first), max_thread_reservation.second, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12429/1/tests/query_test/test_resource_limits.py File tests/query_test/test_resource_limits.py: http://gerrit.cloudera.org:8080/#/c/12429/1/tests/query_test/test_resource_limits.py@22 PS1, Line 22: class TestResourceLimits(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12429/1/tests/query_test/test_resource_limits.py@40 PS1, Line 40: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/12429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I5b5bbbdad5cd6b24442eb6c99a4d38c2ad710007 Gerrit-Change-Number: 12429 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 02:09:50 +0000 Gerrit-HasComments: Yes
