Hello Lars Volker, David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12397
to look at the new patch set (#3).
Change subject: IMPALA-8173: Fix KeyError in run-workload.py
......................................................................
IMPALA-8173: Fix KeyError in run-workload.py
A recent change (IMPALA-7694) causes run-workload.py to fail with a
KeyError due to trying to construct an ImpalaBeeswaxResult without a
query id.
This patch fixes that issue and two related issues:
- This problem was not caught by automated testing even though we run
run-workload.py in run-all-tests.sh because of an issue where
queries that fail to produce results are silently ignored.
- Fixes an issue where queries that fail to produce results would
confusingly produce the error:
'NoneType' object has no attribute 'time_taken'
Testing:
- Ran run-workload.py locally and demonstrated that it works now.
- Ran run-all-tests.sh locally and demonstrated that it fails now when
the KeyError issue isn't fixed.
Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
---
M tests/performance/query_exec_functions.py
M tests/performance/scheduler.py
2 files changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/12397/3
--
To view, visit http://gerrit.cloudera.org:8080/12397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5b8a3c3dd7499335b9290d5667c194e8c0eabd12
Gerrit-Change-Number: 12397
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Thomas Marshall <[email protected]>
