Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 )
Change subject: Add support for compiling using OpenSSL 1.1 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc@76 PS1, Line 76: #else : return TLS1_2_VERSION; : #endif : } Why this change here ? Is there anything wrong with keeping the SSLv23_method()->version? Is it not defined or something ? There seems to be some complication with the logic on RHEL related to detecting the version of the linked OpenSSL library: (https://github.com/apache/impala/commit/a3c0fffa1275c1d1d2770b9fc35885a22dc7edce) http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc@123 PS1, Line 123: EVP_CIPHER_CTX * nit: EVP_CIPHER_CTX* ctx; -- To view, visit http://gerrit.cloudera.org:8080/12420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaccf1b2dedf0d957a2665df8f9afca4139754264 Gerrit-Change-Number: 12420 Gerrit-PatchSet: 1 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 11 Feb 2019 22:39:10 +0000 Gerrit-HasComments: Yes
