Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 )
Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/12365/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/12365/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@100 PS6, Line 100: private static final Logger LOG = LoggerFactory.getLogger(MetastoreEventFactory.class); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/12365/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12365/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@804 PS6, Line 804: when(mockNotificationEvent.getEventId()).thenReturn(eventIdGenerator.incrementAndGet()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12365/6/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1127 PS6, Line 1127: private org.apache.hadoop.hive.metastore.api.Table getTestTable(String dbName, String tblName, line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If116edba51bae139bc003be858b3214c3f0104e3 Gerrit-Change-Number: 12365 Gerrit-PatchSet: 6 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (453) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 03:03:23 +0000 Gerrit-HasComments: Yes
