Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12423 )
Change subject: Enable publishing on the docker-based build ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12423/2/in-docker.py File in-docker.py: http://gerrit.cloudera.org:8080/#/c/12423/2/in-docker.py@57 PS2, Line 57: Maps docker images to BUILD_TARGET_LABELs which is ultimately included : # in the path for each built package It may be worth mentioning here that Impala/bin/bootstrap_toolchain.py contains the logic that depends on these strings. http://gerrit.cloudera.org:8080/#/c/12423/2/in-docker.py@130 PS2, Line 130: S3_BUCKET Maybe add the AWS credential variables to the passthrough list, in case they are supplied for the bucket? - AWS_ACCESS_KEY_ID - AWS_SECRET_ACCESS_KEY - AWS_SESSION_TOKEN -- To view, visit http://gerrit.cloudera.org:8080/12423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32966bf5b5ad32a3caaf2aee0430ea3a67ecb5d6 Gerrit-Change-Number: 12423 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Wed, 13 Feb 2019 16:58:44 +0000 Gerrit-HasComments: Yes
