Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 )
Change subject: IMPALA-7368: Add initial support for DATE type ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/12481/1/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/12481/1/be/src/exprs/utility-functions-ir.cc@218 PS1, Line 218: template StringVal UtilityFunctions::TypeOf(FunctionContext* ctx, const DateVal& input_val); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12481/1/tests/hs2/test_fetch.py File tests/hs2/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/12481/1/tests/hs2/test_fetch.py@180 PS1, Line 180: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py File tests/query_test/test_date_queries.py: http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@20 PS1, Line 20: from copy import copy flake8: F401 'copy.copy' imported but unused http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@25 PS1, Line 25: from tests.common.test_vector import ImpalaTestDimension flake8: F401 'tests.common.test_vector.ImpalaTestDimension' imported but unused http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@27 PS1, Line 27: class TestDateQueries(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@37 PS1, Line 37: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@38 PS1, Line 38: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@39 PS1, Line 39: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/12481/1/tests/query_test/test_date_queries.py@41 PS1, Line 41: \ flake8: E502 the backslash is redundant between brackets -- To view, visit http://gerrit.cloudera.org:8080/12481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea8155ef09557e0afa2f8b2d0b2dc9d0896dc30f Gerrit-Change-Number: 12481 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 16:09:04 +0000 Gerrit-HasComments: Yes
