Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12501 )
Change subject: IMPALA-8191: Wait for additional breakpad processes during test ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12501/1/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: http://gerrit.cloudera.org:8080/#/c/12501/1/tests/custom_cluster/test_breakpad.py@88 PS1, Line 88: def wait_for_all_processes_dead(self, processes, timeout=300): : # For every process in the list we might see the original Impala process plus a forked : # off child that is writing the minidump. To catch both we go through the list twice. : for process in processes * 2: I don't understand this. processes here is a list of pids, and we wait() on each of them. Why does waiting on them multiple times help things? It sounded from your description in the commit message is that the issue is where we enumarate which process to wait for (the impalad or its fork), but that's not what this code is doing. I'm sure I'm confused; let me know where! -- To view, visit http://gerrit.cloudera.org:8080/12501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dcc5fecb9b5f38ae1504aae40f099837cf1bca Gerrit-Change-Number: 12501 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 15 Feb 2019 23:00:54 +0000 Gerrit-HasComments: Yes
