Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12495 )
Change subject: IMPALA-8204: checkout to the right commit of Impala-lzo in buildall.sh ...................................................................... Patch Set 2: > I still think we should write down the depended Impala-lzo version > somewhere. Once I want to build an older version of Impala, I don't > need to guess which Impala-lzo commit should I check out to. it's in bin/bootstrap_development.sh, no? > > There's a benifit to do the checkout in buildall.sh. In the future > when I want to build an older version (but >2.13, >3.2), I just > need to checkout to the right tag in Impala and then run > buildall.sh. It'll bootstrap dependencies including the Impala-lzo > to the corresponding versions. > > If you're developing Impala-lzo, you can first commit it locally, > and then change the depended commit id in impala-config-branch.sh. > I think this is the same with other dependencies. For example, if > we want to bump the version of ORC lib, we need to upgrade it in > native-toolchain project and then change the corresponding version > in impala-config.sh. I understand your argument, but I don't think it's acceptable for a "build" script to change branches of git repos. We could treat impala-lzo like we treat the toolchain (i.e., checked out in bootstrap_toolchain.sh), and then I'd sort of see it as a "build artifact" which can be overridden rather than my source code. (BTW, if you choose to cherrypick the num_unqueued_files that drove this mess, we'll be back to using the same impala-lzo code base in both branches...) -- To view, visit http://gerrit.cloudera.org:8080/12495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I5e4b53d695de04d31d39b6909572907944713ba4 Gerrit-Change-Number: 12495 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 16 Feb 2019 00:34:23 +0000 Gerrit-HasComments: No
