Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12504 )
Change subject: IMPALA-7174: fix test_cancellation for RELEASE builds ...................................................................... IMPALA-7174: fix test_cancellation for RELEASE builds The test was DOA when run against a release build because the debug actions that it depends on were disabled. The fix is to enable the debug actions for release builds, similar to other debug actions. I assume the original motivation of the NDEBUG checks was to avoid adding overhead to release builds. The cost is minimised by quickly checking whether the string is empty before proceeding with any further work. Also remove wonky exception handling - the test was swallowing exceptions but we don't expect that code to throw exceptions. Testing: Looped the test on a release build. Change-Id: I41da7b5ac58a468a8ed117777969906f63df6d4b Reviewed-on: http://gerrit.cloudera.org:8080/10722 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/12504 Reviewed-by: Quanlong Huang <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> --- M be/src/scheduling/admission-controller.cc M be/src/service/client-request-state.cc M be/src/util/debug-util.cc M be/src/util/debug-util.h M tests/custom_cluster/test_admission_controller.py 5 files changed, 14 insertions(+), 21 deletions(-) Approvals: Impala Public Jenkins: Verified Quanlong Huang: Looks good to me, but someone else must approve Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I41da7b5ac58a468a8ed117777969906f63df6d4b Gerrit-Change-Number: 12504 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
