Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12514
Change subject: IMPALA-5031: oversized signed shifts are undefined ...................................................................... IMPALA-5031: oversized signed shifts are undefined Standard section [expr.shift] says that E1 << E2 is undefined if E1 is of signed type and the result cannot be represented in the corresponding unsigned type. We can't simply change 1 << bit_width to 1u << bit_width, though, becuase it is the second argument of the modulo operator, and following [expr.mul], "If the second operand of / or % is zero the behavior is undefined." Change-Id: I7debbd1ca5bd3ae640701ce0e95a12c5059abfd7 --- M be/src/util/rle-test.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/12514/1 -- To view, visit http://gerrit.cloudera.org:8080/12514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7debbd1ca5bd3ae640701ce0e95a12c5059abfd7 Gerrit-Change-Number: 12514 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]>
