Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 )
Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9635/6/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/9635/6/tests/stress/concurrent_select.py@698 PS6, Line 698: timeout = solo_runtime * max(10, query_runner._num_queries_started.value - \ I'm pretty sure this change is the cause of the increased timeouts that Sailesh saw. The problem is that it's using the query-runner-local counts to try to calculate the number of active queries globally. But each runner has only one query at a time, so the second argument to max() is either 0 or 1. The 10x factor here is also kind-of broken anyway since there's no reason queries can't run more than 10x slower under load. -- To view, visit http://gerrit.cloudera.org:8080/9635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10c5dc9b8c2fffc471bac2279e348bc1d1fec3b7 Gerrit-Change-Number: 9635 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Nithya Janarthanan <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 16:57:16 +0000 Gerrit-HasComments: Yes
