Paul Rogers has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12020 )

Change subject: IMPALA-7917 (Part 1): Decouple Sentry from Impala
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

Looks great!

http://gerrit.cloudera.org:8080/#/c/12020/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/12020/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2637
PS12, Line 2637:       
globalState_.maskedPrivilegeReqs.add(Pair.create(privReq, authErrorMsg_));
Nice!



--
To view, visit http://gerrit.cloudera.org:8080/12020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1fd1df0b38ddd7cfa41299e95f5827f8a9e9c1f
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Anonymous Coward (402)
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Wed, 20 Feb 2019 00:06:12 +0000
Gerrit-HasComments: Yes

Reply via email to