Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12560 )
Change subject: IMPALA-8064: Increase RUNTIME_FILTER_WAIT_TIME_MS for slow builds ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/12560/1/tests/query_test/test_runtime_filters.py@27 PS1, Line 27: WAIT_TIME_MS = build_flavor_timeout(60000, slow_build_timeout=200000) nit: do you think it makes sense to add the small comment for the reason behind this value, just so that its not lost between future changes to this test. Maybe just mention the jira id and not the whole reason. -- To view, visit http://gerrit.cloudera.org:8080/12560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib18075c2a480aad1331754cfd89a383dd58b0f2e Gerrit-Change-Number: 12560 Gerrit-PatchSet: 1 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 23 Feb 2019 00:20:58 +0000 Gerrit-HasComments: Yes
