Hello [email protected], Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12573
to review the following change.
Change subject: IMPALA-8244: Fix publishing for non-Docker builds
......................................................................
IMPALA-8244: Fix publishing for non-Docker builds
A previous commit introduced two additional environment variables to control
publishing: PUBLISH_DEPENDENCIES_S3 and PUBLISH_DEPENDENCIES_ARTIFACTORY.
These were set both from init.sh and from functions.sh. However, both init.sh
and functions.sh are sourced, not called, so by the time control reached
functions.sh, the variables were always defined, so the initial value of 0 could
never be overridden. This prevented the artifacts from being published even
if PUBLISH_DEPENDENCIES was set to 1 to request this.
This patch fixes the problem by removing the initialization and definition of
the
dependent variables from init.sh.
A seemingly benign typo is also removed from functions.sh
Tested by running a publishing build with the change using the regular
internal publishing job and observing the published results in the S3
bucket (and verifying build logs).
Change-Id: I4c8c6f4eeb7164e29ebc7c9b80c53da81537f63a
---
M functions.sh
M init.sh
2 files changed, 1 insertion(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/73/12573/1
--
To view, visit http://gerrit.cloudera.org:8080/12573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c8c6f4eeb7164e29ebc7c9b80c53da81537f63a
Gerrit-Change-Number: 12573
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: [email protected] <[email protected]>
