Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12574 )
Change subject: Add ccache support ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Looks reasonable to me. Nice speed improvement. http://gerrit.cloudera.org:8080/#/c/12574/1/docker/debian7.df File docker/debian7.df: http://gerrit.cloudera.org:8080/#/c/12574/1/docker/debian7.df@43 PS1, Line 43: wget "https://www.samba.org/ftp/ccache/ccache-3.3.3.tar.gz"; && \ I recommend moving this into a shell script. We've also tended to sha-check our binaries. E.g.: bin/bootstrap_system.sh:redhat sha512sum -c - <<< 'c8321aa223f70d7e64d3d0274263000cfffb46fbea61488534e26f9f0245d99e9872d0888e35cd3274416392a13f80c748c07750caaeffa5f9cae1220020715f apache-ant-1.9.13-bin.tar.gz' http://gerrit.cloudera.org:8080/#/c/12574/1/init.sh File init.sh: http://gerrit.cloudera.org:8080/#/c/12574/1/init.sh@138 PS1, Line 138: : ${USE_CCACHE=0} : export USE_CCACHE : : : ${CCACHE_MAXSIZE=50G} : export CCACHE_MAXSIZE : : : ${CCACHE_DIR=$SOURCE_DIR/ccache} : export CCACHE_DIR : : # Default ccache_compilercheck is mtime, which considers CC's mtime + size : # to determine if there's a hit. Setting CCACHE_COMPILERCHECK to 'content' : # uses the hash of the compiler instead. : export CCACHE_COMPILERCHECK=${CCACHE_COMPILERCHECK:-content} : : export CCACHE_COMPRESS=1 Do you think these would be better encapsulated in a .ccache.conf file that we create when we bootstrap ccache? -- To view, visit http://gerrit.cloudera.org:8080/12574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieef291d1294a204b0b8da7e7aa4fa642cdd5e144 Gerrit-Change-Number: 12574 Gerrit-PatchSet: 1 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Mon, 25 Feb 2019 17:36:38 +0000 Gerrit-HasComments: Yes
