Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12567 )
Change subject: IMPALA-8239: Fix handling of failed deserialization of row batch ...................................................................... Patch Set 1: (3 comments) Thanks for fixing this. I had one serious question about data_arrival_cv_ and some minor comments about comments. http://gerrit.cloudera.org:8080/#/c/12567/1/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/12567/1/be/src/runtime/krpc-data-stream-recvr.cc@118 PS1, Line 118: // accounting for various counters. Maybe document that 'lock_' must be held via 'lock' here and below. Ok to ignore since it is fairly self-explanatory. http://gerrit.cloudera.org:8080/#/c/12567/1/be/src/runtime/krpc-data-stream-recvr.cc@161 PS1, Line 161: inesrting inserting. Maybe document that this is for errors that occur within KrpcDataStreamRecvr, whereas 'is_cancelled_' tracks cancellations from outside KrpcDataStreamRecvr. http://gerrit.cloudera.org:8080/#/c/12567/1/be/src/runtime/krpc-data-stream-recvr.cc@346 PS1, Line 346: status_.MergeStatus(status); Should we signal data_arrival_cv_ here? Since the loop above depends on this. -- To view, visit http://gerrit.cloudera.org:8080/12567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa74937b046d95484887533be548249e96078755 Gerrit-Change-Number: 12567 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 25 Feb 2019 19:30:34 +0000 Gerrit-HasComments: Yes
