Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12568 )
Change subject: IMPALA-7645: Add a query option to set the default table file format ...................................................................... Patch Set 4: Code-Review+1 (1 comment) LGTM. Had one thought about naming but I think I'm fine with this. http://gerrit.cloudera.org:8080/#/c/12568/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12568/4//COMMIT_MSG@9 PS4, Line 9: TABLE_FILE_FORMAT Maybe DEFAULT_FILE_FORMAT? Only because people might be confused about whether it overrides the "STORED AS". Actually I guess they probably won't be. -- To view, visit http://gerrit.cloudera.org:8080/12568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic857c38076d973ad749a41fecd1b470c7881db5e Gerrit-Change-Number: 12568 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Feb 2019 21:19:08 +0000 Gerrit-HasComments: Yes
