Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12549 )
Change subject: IMPALA-7975 : Improve supportability of the automatic invalidate feature ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog-server.cc@528 PS4, Line 528: Value error(status.GetDetail().c_str(), document->GetAllocator()); > line too long (100 > 90) Done http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.h File be/src/catalog/catalog.h: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.h@111 PS4, Line 111: Status GetEventProcessorMetrics(TGetEventProcessorMetricsResponse* response); > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: http://gerrit.cloudera.org:8080/#/c/12549/4/be/src/catalog/catalog.cc@163 PS4, Line 163: Status Catalog::GetEventProcessorMetrics(TGetEventProcessorMetricsResponse* response) { > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/12549/3/fe/src/main/java/org/apache/impala/catalog/events/ExternalEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/ExternalEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/12549/3/fe/src/main/java/org/apache/impala/catalog/events/ExternalEventsProcessor.java@56 PS3, Line 56: TGetEventProcessorMetricsResponse getEventProcessorMetrics(); > Nit: Drop "Get", does not add much info. Done -- To view, visit http://gerrit.cloudera.org:8080/12549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23cb3aa866879eca03c64ab881796eaa9caa0337 Gerrit-Change-Number: 12549 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Feb 2019 00:00:08 +0000 Gerrit-HasComments: Yes
