Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12589 )
Change subject: IMPALA-8249: End-to-end test framework doesn't read aggregated counters properly ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12589/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12589/1//COMMIT_MSG@9 PS1, Line 9: Updated compute_aggregation() function to not read the pretty-printed : value from the runtime profile, but the accurate value which is at : the end of the line in parenthesis. > Can you add an example output like you have in the JIRA and how the existin Extended the commit message. http://gerrit.cloudera.org:8080/#/c/12589/1/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/12589/1/tests/common/test_result_verifier.py@525 PS1, Line 525: field_regex = "{0}: \d+(?:.\d+[KMB])? \((\d+)\)".format(field) > Can you add a comment explaining what this regex is matching? It would be n Updated the comment of the function and added some explanation for the regex. Do you have a recommendation/example for such tests? Currently, when we use 'aggregation(SUM, ...)' in a profile, it implicitly tests the verification mechanism as well. However, currently we don't really have very big numbers in the tests for these kind of fields, so it doesn't go wrong with pretty-printing. We'll have big numbers when we merge Parquet page filtering, though. That's where I ran into this issue. -- To view, visit http://gerrit.cloudera.org:8080/12589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a6fc0d3f7cbaa87aa848cdafffad21fb1514930 Gerrit-Change-Number: 12589 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Feb 2019 17:06:47 +0000 Gerrit-HasComments: Yes
