Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )
Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml File docs/topics/impala_parquet.xml: http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1270 PS3, Line 1270: <stentry>BINAR annotated with the UTF8 OriginalType</stentry> > A "Y" is missing from the end of "BINAR[Y]" Done http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1314 PS3, Line 1314: <stentry>INT64 annotated with the TIMESTAMP_MICROS</stentry> > "OriginalType" missing from "INT64 annotated with the TIMESTAMP_MICROS [Ori Done http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml File docs/topics/impala_timestamp.xml: http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@221 PS3, Line 221: values with : the <codeph>OriginalType</codeph> annotation > Change Done http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@224 PS3, Line 224: with the <codeph>LogicalType</codeph> annotation specifies whether UTC to local > Change Done http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@262 PS3, Line 262: default for a performance reason, to avoid unexpected incompatibility problems > This sentence is hard to understand, I would break into two sentences like Done -- To view, visit http://gerrit.cloudera.org:8080/12559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654 Gerrit-Change-Number: 12559 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 03:48:31 +0000 Gerrit-HasComments: Yes
