Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12635 )
Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12635/3/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/3/be/src/service/query-options.cc@235 PS3, Line 235: if (iequals(value, "none") || iequals(value, "0")) { > optional: these big else if chains look error prone - it would be probably I don't know if it's a big issue, but this will make the operation to be linear O(N) (since we have to iterate the map) vs constant O(1). Unfortunately in the C++ Thrift generated code, I only see _THdfsCompression_VALUES_TO_NAMES and no _THdfsCompression_NAMES_TO_VALUES, which could make the operation constant by doing a two lookups depending on whether the value is string or integer. Let me know what you think? http://gerrit.cloudera.org:8080/#/c/12635/3/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/12635/3/tests/metadata/test_compute_stats.py@79 PS3, Line 79: @SkipIfS3.eventually_consiste > Does this have to be executed serially? It should not collide with other te Yup, I don't think we need it. Removed. -- To view, visit http://gerrit.cloudera.org:8080/12635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb546fbd3d2a02e0ed30d85a33a04852bed9dd2 Gerrit-Change-Number: 12635 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 28 Feb 2019 15:43:32 +0000 Gerrit-HasComments: Yes
