Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12641 )
Change subject: IMPALA-8266 : Event filtering logic may not filter all the events ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12641/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/12641/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@189 PS1, Line 189: fromIndex++; Really awkward and error prone. Do we need to remove items from the list? Can we just do: for (MetastoreEvent : metastoreEvents) { if (whatever) { process } } If this loop consumes all events, no need to return the list. The GC will get rid of it. Or, if we want to remove some items: int i = 0; while (I < metastoreEvents.size()) { MetastoreEvent event = metastoreEvents.get(); if (consumed) metastoreEvents.remove(i); else I++; } -- To view, visit http://gerrit.cloudera.org:8080/12641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeaa26017ee223cca18344e5e1d6ace87200fd9c Gerrit-Change-Number: 12641 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Comment-Date: Fri, 01 Mar 2019 03:24:05 +0000 Gerrit-HasComments: Yes
