Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12638 )
Change subject: IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios ...................................................................... IMPALA-8264: Fix overflow in SystemStateInfo::ComputeCpuRatios We pass '0' as the initial value to std::accumulate(), which causes it to use int32_t for its internal state, which then overflows when values read from /proc/stat get too large. The fix is to initialize it with '0L' to make it use int64_t. Change-Id: I46dfb7264e85a3da492e383caaa6853d8ef95f35 Reviewed-on: http://gerrit.cloudera.org:8080/12638 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/system-state-info-test.cc M be/src/util/system-state-info.cc M be/src/util/system-state-info.h 3 files changed, 16 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12638 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I46dfb7264e85a3da492e383caaa6853d8ef95f35 Gerrit-Change-Number: 12638 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]>
